Removed strip() method in load_value() method from data.py file#416
Merged
akaila-splunk merged 2 commits intodevelopfrom Nov 25, 2021
Merged
Removed strip() method in load_value() method from data.py file#416akaila-splunk merged 2 commits intodevelopfrom
akaila-splunk merged 2 commits intodevelopfrom
Conversation
- removed strip() method in load_value() method, so now response value contain leading and trailing spaces while printing data in console
ghost
reviewed
Nov 19, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
What do you think about adding test for this fix?
- added test case for check spaces in username
Contributor
Author
Hi @arys-splunk , Added new test case for the fix, let us know if any other changes are required |
I am not familiar with the code, let's wait what @zenmoto and @fantavlik say. |
fantavlik
approved these changes
Nov 24, 2021
Contributor
fantavlik
left a comment
fantavlik
left a comment
There was a problem hiding this comment.
Looks good, nice catch @akaila-splunk
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
service.storage_passwords.listmisses space inusernamefield #400