fix: remove security notice UI from ask github

[msukkari]

Remove the security notice from the askfd.fxlcf.dpdns.org sign-up UI.

The security notice is not relevant for askfd.fxlcf.dpdns.org, where users are required to log in, and is removed when EXPERIMENT_ASK_GH_ENABLED is active.

---

Linear Issue: SOU-560

  

Summary by CodeRabbit

• Refactor
  • Updated the authentication security notice display behavior to be conditionally hidden based on configuration.

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[coderabbitai]

Walkthrough

This change replaces the security notice control mechanism in AuthMethodSelector from a closable prop to a hide prop. LoginModal is updated to pass hideSecurityNotice={true} instead of securityNoticeClosable={true}, and AuthMethodSelector now conditionally renders the security notice based on the new prop value.

Changes

Cohort / File(s)	Summary
AuthMethodSelector Component packages/web/src/app/components/authMethodSelector.tsx	Added optional hideSecurityNotice prop (default false) to control security notice visibility. Updated conditional rendering logic to display AuthSecurityNotice only when hideSecurityNotice is false.
LoginModal Usage packages/web/src/app/[domain]/askgh/[owner]/[repo]/components/loginModal.tsx	Updated AuthMethodSelector prop usage from securityNoticeClosable={true} to hideSecurityNotice={true}.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• chore(ask_gh): Add login modal #875: Introduced the LoginModal component using AuthMethodSelector with securityNoticeClosable prop, which this PR now updates to use the new hideSecurityNotice prop instead.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title 'fix: remove security notice UI from ask github' accurately describes the main change: hiding the security notice in the askgh sign-up flow through a new hideSecurityNotice prop and its implementation in LoginModal.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cursor/SOU-560-sign-up-security-notice-367f

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

@msukkari your pull request is missing a changelog!