Skip to content

[Upgrade] Move to NSs, autoloading with PSR-4 and dependency management#10

Merged
underscorephil merged 1 commit intosoftlayer:masterfrom
phansys:composer
Sep 10, 2015
Merged

[Upgrade] Move to NSs, autoloading with PSR-4 and dependency management#10
underscorephil merged 1 commit intosoftlayer:masterfrom
phansys:composer

Conversation

@phansys
Copy link
Contributor

@phansys phansys commented Aug 21, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Tests pass?
Fixed tickets #8
License MIT
Doc PR

Fixes #8.

  • Moved class names to namespaces respecting PSR-4
    autoload standard.
  • Added Composer as dependency manager

In order to allow this library to be installed with Composer, it must be submitted
in Packagist after this PR is merged.

@phansys phansys force-pushed the composer branch 4 times, most recently from 3e00f4e to 450a68d Compare August 21, 2015 17:33
@underscorephil
Copy link
Contributor

underscorephil commented Sep 8, 2015

Thanks for the PR!

Looking at this.

@phansys
Copy link
Contributor Author

phansys commented Sep 8, 2015

Thank you @underscorephil. Please let me know if you have any doubt or comment about these changes.

underscorephil
underscorephil reviewed Sep 10, 2015
View reviewed changes
src/XmlRpcClient.php Outdated
Copy link
Contributor

@underscorephil underscorephil Sep 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be self:: here instead of XmlRpcClinet::?

@underscorephil
Copy link
Contributor

underscorephil commented Sep 10, 2015

@phansys ready to merge after I get your response on the line note

@phansys
[Upgrade] Move to NSs, autoloading with PSR-4 and dependency management
4258aac 
| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   |
| Fixed tickets | softlayer#8
| License       | MIT
| Doc PR        |

Fixes softlayer#8.

* Moved class names to namespaces respecting [PSR-4](http://www.php-fig.org/psr/psr-4/)
  autoload standard.
* Added [Composer](https://getcomposer.org/) as dependency manager

In order to allow this library to be installed with Composer, it must be submitted
in [Packagist](https://packagist.org/packages/submit) after this PR is merged.
@phansys
Copy link
Contributor Author

phansys commented Sep 10, 2015

Sorry for the delay @underscorephil. PR updated and rebased.
I left the class name instead self keyword before because I was affraid that syntax were not supported in earlier PHP versions, but it seems to be supported from +5.2.4, so isn't an issue there: https://3v4l.org/vGqD7.

Thank you.

underscorephil added a commit that referenced this pull request Sep 10, 2015
@underscorephil
Merge pull request #10 from phansys/composer
a209af1 
[Upgrade] Move to NSs, autoloading with PSR-4 and dependency management
@underscorephil underscorephil merged commit a209af1 into softlayer:master Sep 10, 2015
@phansys phansys deleted the composer branch September 10, 2015 19:39
@phansys
Copy link
Contributor Author

phansys commented Sep 10, 2015

Nice to find this library in Packagist!
It would be nice if you could tag a release from 0.x branch in order to allow people looking for a earlier stable release to use it.

Ping @underscorephil.

@phansys phansys mentioned this pull request Dec 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Client to Adhere to FIG Standards

2 participants

@phansys @underscorephil