Skip to content

feat(auth): auto-prompt login when no workspaces connected#331

Merged
mwbrooks merged 5 commits intomainfrom
ale-run-cmd-auto-login
Feb 13, 2026
Merged

feat(auth): auto-prompt login when no workspaces connected#331
mwbrooks merged 5 commits intomainfrom
ale-run-cmd-auto-login

Conversation

@srtaalej
Copy link
Contributor

@srtaalej srtaalej commented Feb 5, 2026

Changelog

We now prompt a login if no authentications are available when running a command that requires credentials instead of exiting with an error.

Summary

When running commands like slack run without any authenticated workspaces, automatically prompt the user to sign in instead of showing an error.
Screenshot 2026-02-05 at 12 25 47 PM

Manually test by clearing credentials (slack logout --all) and running slack run

Requirements

@srtaalej srtaalej self-assigned this Feb 5, 2026
@srtaalej srtaalej added the enhancement M-T: A feature request for new functionality label Feb 5, 2026
@srtaalej srtaalej requested a review from a team as a code owner February 5, 2026 17:29
@srtaalej srtaalej added the semver:minor Use on pull requests to describe the release version increment label Feb 5, 2026
@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@784de53). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/prompts/app_select.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage        ?   64.67%           
=======================================
  Files           ?      212           
  Lines           ?    17782           
  Branches        ?        0           
=======================================
  Hits            ?    11501           
  Misses          ?     5206           
  Partials        ?     1075           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@srtaalej
Copy link
Contributor Author

srtaalej commented Feb 5, 2026

Dear kind reviewers,
changes to @app_select.go are working as expected. I've tested with the following commands

  ./bin/slack deploy
  ./bin/slack activity
  ./bin/slack trigger list
  ./bin/slack env list
  ./bin/slack datastore query

🫡

@mwbrooks mwbrooks added this to the Next Release milestone Feb 9, 2026
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Works beautifully @srtaalej and very elegant implementation! 💅🏻

🧪 Testing locally works well on both slack run and slack manifest validate. Also confirmed commands like slack create and slack auth list do not prompt to login.

✏️ I've left 1 suggestion but that would be nice to add, but non-blocking.

@zimeg zimeg added the changelog Use on updates to be included in the release notes label Feb 9, 2026
@mwbrooks mwbrooks merged commit 3eef3bd into main Feb 13, 2026
8 checks passed
@mwbrooks mwbrooks deleted the ale-run-cmd-auto-login branch February 13, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog Use on updates to be included in the release notes enhancement M-T: A feature request for new functionality semver:minor Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants