Update request signing to work for any content type#44
Merged
shaydewael merged 4 commits intoslackapi:masterfrom Dec 12, 2018
Merged
Update request signing to work for any content type#44shaydewael merged 4 commits intoslackapi:masterfrom
shaydewael merged 4 commits intoslackapi:masterfrom
Conversation
9 tasks
aoberoi
approved these changes
Dec 12, 2018
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #41
Server is currently looking in
request.datafor raw request body in the verify_signature method. This is fine for intended functionality (for use with the Events API), but developers that want to use the function to handle other content-types (like with Slash commands) can't right now. This fixes that by usingrequest.get_data()instead, which works regardless of content-type 😄Requirements (place an
xin each[ ])