Skip to content

Update request signing to work for any content type#44

Merged
shaydewael merged 4 commits intoslackapi:masterfrom
shaydewael:request-signing-update
Dec 12, 2018
Merged

Update request signing to work for any content type#44
shaydewael merged 4 commits intoslackapi:masterfrom
shaydewael:request-signing-update

Conversation

@shaydewael
Copy link
Contributor

Summary

Fixes #41

Server is currently looking in request.data for raw request body in the verify_signature method. This is fine for intended functionality (for use with the Events API), but developers that want to use the function to handle other content-types (like with Slash commands) can't right now. This fixes that by using request.get_data() instead, which works regardless of content-type 😄

Requirements (place an x in each [ ])

Copy link
Contributor

@Roach Roach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @shanedewael!

@wooddar
Copy link

wooddar commented Dec 12, 2018

🎉

@shaydewael shaydewael merged commit 59e30f2 into slackapi:master Dec 12, 2018
@shaydewael shaydewael deleted the request-signing-update branch December 12, 2018 17:51
@shaydewael shaydewael mentioned this pull request Dec 13, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues signing incoming slash command requests (Flask)

4 participants