-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix(mcp): pass timeout to SDK callTool to override 60s default #3101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
4f69d32 to
510dc3e
Compare
510dc3e to
fa918cc
Compare
Greptile OverviewGreptile SummaryAdded timeout parameter to the MCP SDK's Key Changes:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Service as McpService
participant Client as McpClient
participant SDK as MCP SDK Client
participant Server as MCP Server
Note over Service: Config has timeout: 30000ms or custom
Service->>Client: createClient(config)
Note over Client: Stores config with timeout
Client->>SDK: new Client()
Service->>Client: callTool(toolCall)
Note over Client: Uses this.config.timeout || 600000
Client->>SDK: callTool(params, undefined, {timeout})
Note over SDK: Overrides 60s DEFAULT_REQUEST_TIMEOUT_MSEC
SDK->>Server: HTTP Request with configured timeout
Server-->>SDK: Tool result
SDK-->>Client: sdkResult
Client-->>Service: McpToolResult
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Summary
Type of Change
Testing
Tested manually
Checklist