fix(notes): ghost edges

[icecrasher321]

Summary

Ghost edges from notes block

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
docs	Skipped		Jan 24, 2026 7:01pm

[greptile-apps]

Greptile Summary

This PR fixes ghost edges from notes blocks by centralizing edge validation logic. The core change introduces a filterValidEdges function in the store that systematically filters out invalid edges including those connected to annotation-only blocks (notes) and trigger blocks. This validation is now applied consistently across all edge operations: when adding edges via batchAddEdges, when loading state via setState, and when loading deployed state via loadDeployedState.

Key improvements:

• Centralized edge validation in store.ts with isValidEdge and filterValidEdges helper functions
• Simplified edge filtering logic in workflow.tsx by removing redundant checks (now handled by store)
• Extracted auto-connect validation into reusable isAutoConnectSourceCandidate helper in workflow.tsx
• Improved trigger block detection by using TriggerUtils.isTriggerBlock() instead of checking config.category === 'triggers' directly
• Added logging for filtered invalid edges to aid debugging

The fix ensures that edges connected to notes blocks (which are annotation-only and non-executable) are filtered out at the store level, preventing them from persisting in the workflow state.

Confidence Score: 4/5

• This PR is safe to merge with low risk - it centralizes edge validation logic and adds defensive filtering
• The changes are well-structured and improve code quality by centralizing validation logic. The fix addresses a real bug (ghost edges from notes blocks) with a systematic approach. The use of helper functions improves maintainability. However, given the complexity of the workflow editor and the lack of automated tests for this specific scenario, there's a small risk of edge cases. The validation logic is now more defensive and consistent across all edge operations.
• No files require special attention - both files have clean, well-structured changes

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx	Simplified edge filtering logic and extracted auto-connect validation into reusable helper, improving code maintainability and consistency
apps/sim/stores/workflows/workflow/store.ts	Centralized edge validation logic with filterValidEdges function to prevent ghost edges from notes blocks and invalid connections across all edge operations

Sequence Diagram

sequenceDiagram
    participant User
    participant WorkflowUI as Workflow UI (workflow.tsx)
    participant Store as WorkflowStore (store.ts)
    participant Validation as Edge Validation

    Note over User,Validation: Edge Creation Flow
    User->>WorkflowUI: Creates/drops block connection
    WorkflowUI->>WorkflowUI: Check isAnnotationOnlyBlock(source/target)
    alt Source or Target is Note block
        WorkflowUI-->>User: Reject connection
    else Valid block types
        WorkflowUI->>WorkflowUI: Check TriggerUtils.isTriggerBlock(target)
        alt Target is trigger block
            WorkflowUI-->>User: Reject connection
        else Valid connection
            WorkflowUI->>Store: batchAddEdges(edges)
            Store->>Validation: filterValidEdges(edges, blocks)
            Validation->>Validation: For each edge: isValidEdge()
            Validation->>Validation: Check source/target blocks exist
            Validation->>Validation: Check !isAnnotationOnlyBlock(source.type)
            Validation->>Validation: Check !isAnnotationOnlyBlock(target.type)
            Validation->>Validation: Check !TriggerUtils.isTriggerBlock(target)
            alt Edge is invalid
                Validation->>Validation: logger.warn (filtered invalid edge)
                Validation-->>Store: Remove from edge list
            else Edge is valid
                Validation-->>Store: Keep edge
            end
            Store->>Store: Add valid edges to state
            Store-->>WorkflowUI: State updated
            WorkflowUI-->>User: Visual update
        end
    end

    Note over User,Validation: State Hydration Flow
    Store->>Store: loadDeployedState() / setState()
    Store->>Validation: filterValidEdges(edges, blocks)
    Validation->>Validation: Filter out ghost edges
    Store->>Store: Update state with valid edges only
    Store-->>WorkflowUI: Clean state (no ghost edges)

Loading

[icecrasher321]

@cursor review

[icecrasher321]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

[icecrasher321]

@cursor review

[icecrasher321]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR