Skip to content

schema-based parsing: fix handling non-existent fields in schema #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piotrrzysko merged 1 commit into from
May 22, 2024
Merged

schema-based parsing: fix handling non-existent fields in schema #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/org/simdjson/ConstructorArgumentsMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ ConstructorArgument get(byte[] buffer, int len) {
int place = findPlace(buffer, len);
for (int i = 0; i < capacity; i++) {
byte[] key = keys[place];
if (key == null) {
return null;
}
if (Arrays.equals(key, 0, key.length, buffer, 0, len)) {
return arguments[place];
}
Expand Down
19 changes: 19 additions & 0 deletions src/test/java/org/simdjson/ObjectSchemaBasedParsingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,25 @@ public void listsWithoutElementTypeAreNotSupported() {
.hasMessage("Undefined list element type.");
}

@Test
public void issue50() {
// given
SimdJsonParser parser = new SimdJsonParser();
byte[] json = toUtf8("{\"name\": \"John\", \"age\": 30, \"aaa\": 1, \"bbb\": 2, \"ccc\": 3}");

// when
Issue50 object = parser.parse(json, json.length, Issue50.class);

// then
assertThat(object.aaa()).isEqualTo(1);
assertThat(object.bbb()).isEqualTo(2);
assertThat(object.ccc()).isEqualTo(3);
}

private record Issue50(long aaa, long bbb, long ccc) {

}

private record RecordWithExplicitFieldNames(@JsonFieldName("ąćśńźż") long firstField,
@JsonFieldName("\u20A9\u0E3F") long secondField,
@JsonFieldName("αβγ") long thirdField,
Expand Down