Skip to content

Conversation

@pdiakumis
Copy link
Collaborator

Just adding some small doc notes and cleaning the log messages a bit.
Also cleaned up/updated GitHub Action workflow.

See commit messages for details.

- bump docker/login-action v1 -> v2
- bump actions/checkout v2 -> v3
- docker build: target linux/amd64 platform
- Dockerfile: silence curl
@pdiakumis pdiakumis requested a review from sigven June 22, 2022 13:32
@pdiakumis
Copy link
Collaborator Author

I'm also getting the following warning when using the --estimate_tmb option:

Warning message:
`gather_()` was deprecated in tidyr 1.2.0.
Please use `gather()` instead.

I've seen it before and I think it was from a dependency of a dependency, will try and remember.

@sigven
Copy link
Owner

sigven commented Jun 22, 2022

I'm also getting the following warning when using the --estimate_tmb option:

Warning message:
`gather_()` was deprecated in tidyr 1.2.0.
Please use `gather()` instead.

I've seen it before and I think it was from a dependency of a dependency, will try and remember.

Yeah, I've noticed that one too, and I think you're right (dep of a dep)

@pdiakumis
Copy link
Collaborator Author

Adding it here too - that warning is from plotly, see plotly/plotly.R#2125.
And the backtrace:

Backtrace:
 1. plotly::ggplotly(tmb_plot_site)
 2. plotly:::ggplotly.ggplot(tmb_plot_site)
 3. plotly::gg2list(...)
 4. plotly:::layers2traces(data, prestats_data, layout, plot)
 6. plotly:::to_basic.GeomHline(...)
 7. tidyr::gather_(...)

@pdiakumis pdiakumis marked this pull request as draft June 23, 2022 08:48
@pdiakumis pdiakumis marked this pull request as ready for review June 26, 2022 05:34
@pdiakumis
Copy link
Collaborator Author

Just cleaned up/simplified a couple of the dicts, ready for review now.

Copy link
Owner

@sigven sigven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Peter. Thanks a lot for doing these clean-ups.. :-)

@sigven sigven merged commit fa03c91 into master Jun 27, 2022
@sigven sigven deleted the docs branch June 27, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants