feat: support improvement commit type #149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
That doesn't seems to be part of the spec and it looks like it's a commitizen only decision to add this type. The conventional-changelog preset doesn't implement it: https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-changelog-conventionalcommits/writer-opts.js#L162 If it were to be supported by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit type is supported by
commitizenvia commitizen/conventional-commit-types#13, though it's not officially part of the conventionalcommits spec as ofv1.0.0(it was previously included inv1.0.0-beta4).It'd be nice to find consensus on whether this type is valid under the conventionalcommits - feel free to push back on this changeset, and I can instead suggest a revert to commitizen/conventional-commit-types#13.