Skip to content

Comments

DCE/RPC - Add more testing#4921

Merged
gpotter2 merged 14 commits intosecdev:masterfrom
gpotter2:dcerpc-tests
Feb 23, 2026
Merged

DCE/RPC - Add more testing#4921
gpotter2 merged 14 commits intosecdev:masterfrom
gpotter2:dcerpc-tests

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Feb 15, 2026

  • add more tests to DCE/RPC
  • fix NTLM server checking of username
  • minor smbclient fix
  • improve endpoint mapper resilliency

fixes #4926

@codecov
Copy link

codecov bot commented Feb 15, 2026

Codecov Report

❌ Patch coverage is 65.95745% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.15%. Comparing base (2c787cd) to head (1e60f8f).
⚠️ Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/msrpce/rpcclient.py 42.85% 8 Missing ⚠️
scapy/layers/msrpce/rpcserver.py 52.94% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4921      +/-   ##
==========================================
+ Coverage   80.10%   80.15%   +0.05%     
==========================================
  Files         370      370              
  Lines       91733    91759      +26     
==========================================
+ Hits        73482    73553      +71     
+ Misses      18251    18206      -45     
Files with missing lines Coverage Δ
scapy/config.py 84.74% <100.00%> (+6.31%) ⬆️
scapy/layers/dcerpc.py 90.58% <100.00%> (+0.56%) ⬆️
scapy/layers/ntlm.py 81.32% <100.00%> (+0.05%) ⬆️
scapy/layers/smbclient.py 74.38% <100.00%> (ø)
scapy/tools/UTscapy.py 65.33% <100.00%> (+0.21%) ⬆️
scapy/layers/msrpce/rpcclient.py 57.58% <42.85%> (+0.24%) ⬆️
scapy/layers/msrpce/rpcserver.py 84.57% <52.94%> (-3.43%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 merged commit c9c91ba into secdev:master Feb 23, 2026
22 of 24 checks passed
@gpotter2 gpotter2 deleted the dcerpc-tests branch February 23, 2026 00:09
evverx added a commit to evverx/scapy that referenced this pull request Feb 23, 2026
to prevent the tests from failing with
```
 ###(000)=[failed] [C706 MGMT] - Import layer
 ...
 ModuleNotFoundError: No module named 'scapy.layers.msrpce.raw.mgmt'

 ###(001)=[failed] [C706 MGMT] - Dissect rpc__mgmt_inq_if_ids_Response
 ...
 >>> pkt = rpc__mgmt_inq_if_ids_Response(DATA)
 NameError: name 'rpc__mgmt_inq_if_ids_Response' is not defined
```

scapy-rpc isn't packaged so it has to be installed using pip instead of
Build-Requires as usual.

It's a follow-up to secdev#4921.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DCE/RPC connect_and_bind and ndr64=false failed

1 participant