fixed KeyError on timessent in sndrcv when an error happens during a send#1937
Closed
epozzobon wants to merge 2 commits intosecdev:masterfrom
Closed
fixed KeyError on timessent in sndrcv when an error happens during a send#1937epozzobon wants to merge 2 commits intosecdev:masterfrom
epozzobon wants to merge 2 commits intosecdev:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1937 +/- ##
==========================================
- Coverage 86.35% 86.35% -0.01%
==========================================
Files 196 196
Lines 44339 44340 +1
==========================================
- Hits 38290 38289 -1
- Misses 6049 6051 +2
|
Member
|
Thanks for the PR & sorry for the late reply. |
Member
|
@gpotter2 should we close this PR? |
Member
|
It will be closed by #1999 |
Member
|
OK, I will close it as this PR will never be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in sndrcv, when an error happens during the send operation it gets logged and execution continues. However, since timessent is not populated, a KeyError will be raised at the line
p.sent_time = timessent[i]. I added a check to verify that the key is present in the timessent dict.This PR also fixes ISOTPSoftSocket.sr1 not returning after the specified timeout, and I added 2 unit tests for that.