Refactoring of ReceiveThread in ISOTPSoftSocket#1756
Conversation
scapy/contrib/isotp.py
Outdated
There was a problem hiding this comment.
Do you think you could remove the timeout, then the whole while loop, to simply use sniff ?
The stop_filter will take care of exiting
There was a problem hiding this comment.
As far as I understood the stop_filter, an exit can only happen, if a message is received.
If this is the case, I can not close the socket, if no further message is received. Sending a "fake message" just to trigger the execution of stop_filter inside close won't work, since I can not inject a message into the CAN socket.
Do you see a possibility to trigger the execution of stop_filter without a receive of a message?
There was a problem hiding this comment.
Correct... I had a prototype #1523 of a such implementation, but that wasnt clean enough (now it's outdated).
I'll come back to you if i get any additional options available
There was a problem hiding this comment.
Thanks. I would be happy, if I could avoid that timeout.
Codecov Report
@@ Coverage Diff @@
## master #1756 +/- ##
==========================================
+ Coverage 85.51% 85.53% +0.01%
==========================================
Files 181 181
Lines 42201 42195 -6
==========================================
+ Hits 36089 36091 +2
+ Misses 6112 6104 -8
|
polybassa
force-pushed
the
ISOTPSoftSocketImprovement
branch
from
789bf55 to
19ab270
Compare
This should remove packet losses in ISOTPSoftSocket
polybassa
force-pushed
the
ISOTPSoftSocketImprovement
branch
from
19ab270 to
d9ebe12
Compare
|
It's still ugly, but better than what's in place ATM |
|
I totally agree. |
4 participants
This should reduce packet losses in ISOTPSoftSocket