Conversation
| ) | ||
| assert all(table.obs["instance_id"] == range(100)) | ||
|
|
||
| assert all(table.obs["instance_id"] == range(1, 100)) |
There was a problem hiding this comment.
here the labels has values 0,100 but the 0 element is background, so is effectively filtered in the left/right joins when get_element_instances is called on labels. Hence the indices of the instances are different.
|
@melonora here I would also need your green light since, due to the change of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
==========================================
- Coverage 91.93% 91.91% -0.03%
==========================================
Files 44 44
Lines 6661 6666 +5
==========================================
+ Hits 6124 6127 +3
- Misses 537 539 +2
|
There was a problem hiding this comment.
Hi @giovp, LGTM! However as you said I agree that it does not make sense to have it in the join, but I would add it in the extra explanation of the docstring for the function before merging, but for now I pre-approve. Did you already check whether any tests on the other repos fail?
|
@melonora indeed some tests in |
closes #614