Skip to content

Comments

Legend order is now deterministic#143

Merged
timtreis merged 3 commits intomainfrom
bugfix/issue104-legend-coloring-doesnt-match-with-plot-in-render_shapes
Aug 18, 2023
Merged

Legend order is now deterministic#143
timtreis merged 3 commits intomainfrom
bugfix/issue104-legend-coloring-doesnt-match-with-plot-in-render_shapes

Conversation

@timtreis
Copy link
Member

No description provided.

@timtreis timtreis linked an issue Aug 16, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #143 (c80ef38) into main (81070f3) will not change coverage.
The diff coverage is 33.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #143   +/-   ##
=======================================
  Coverage   76.53%   76.53%           
=======================================
  Files          10       10           
  Lines        1219     1219           
=======================================
  Hits          933      933           
  Misses        286      286           
Files Changed Coverage Δ
src/spatialdata_plot/pl/utils.py 60.79% <0.00%> (ø)
src/spatialdata_plot/pl/render.py 91.76% <100.00%> (ø)

@timtreis timtreis added the bug Something isn't working label Aug 16, 2023
Copy link
Collaborator

@Sonja-Stockhaus Sonja-Stockhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@timtreis timtreis merged commit a77e2f6 into main Aug 18, 2023
@timtreis timtreis deleted the bugfix/issue104-legend-coloring-doesnt-match-with-plot-in-render_shapes branch August 18, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Legend coloring doesn't match with plot in render_shapes

3 participants