Merged
Conversation
Thegaram
reviewed
Aug 16, 2024
added 2 commits
August 18, 2024 20:28
zimpha
reviewed
Aug 19, 2024
colinlyguo
changed the title
* refactor: move some common functions to encoding * fix golint
Thegaram
previously approved these changes
Aug 21, 2024
Co-authored-by: Péter Garamvölgyi <th307q@gmail.com>
zimpha
approved these changes
Aug 22, 2024
Thegaram
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
Added a flag
conditionalEncodeto enable rollup-relayer and l2geth-verifier to determine when to enable this.PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Breaking change label
Does this PR have the
breaking-changelabel?