Open
Conversation
Member
Author
|
What do you think, @DominikKamp @mmghannam @Opt-Mucca ? This comes after #1168 . Would you be okay with ignoring performance tests in the pipelines and relying on local performance runs? I can also add a github action that would write to the PR whenever these tests were failing, and we could decide if it was relevant. |
Contributor
|
I do not really know what is the point of these one-sided performance tests, but if they matter, increasing the threshold factor to 1.5 might be better than just dropping them completely. |
Collaborator
|
I don't think these pipelines are intended to have performance tests in them, so I don't see a problem with disabling them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.