Add ruff and remove everything it replaces#68
Merged
elevans merged 4 commits intoscijava:mainfrom Aug 23, 2024
Merged
Conversation
Member
|
I guess this still needs to be removed/replaced, otherwise flake will still bark: scyjava/.github/workflows/build.yml Lines 61 to 64 in bf5910e |
Contributor
Author
|
Ah of course, missed a spot |
jschneidereit
changed the title
jschneidereit
force-pushed
the
jschneidereit/64-add-ruff
branch
from
868e98f to
8e2eea4
Compare
elevans
force-pushed
the
jschneidereit/64-add-ruff
branch
5 times, most recently
from
c3c4d0e to
a435a93
Compare
elevans
force-pushed
the
jschneidereit/64-add-ruff
branch
from
a435a93 to
8e2eea4
Compare
This commit resolves an unusual bug where pytest fails to collect the results of the jep test, resulting in failing CI jobs. I was able to reproduce this locally, sometimes, with openjdk=8. There must be a race condition involved with the bug as it doesn't always fail. The crash is a seg fault.
elevans
changed the title
Because we are no longer using the anaconda default channel we need to obtain build from pypi.
Member
|
Thanks @jschneidereit for this PR! |
imagejan
reviewed
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64.