feat: support pytest 9's new config#681
Merged
henryiii merged 2 commits intoscientific-python:mainfrom Nov 10, 2025
Merged
Conversation
Signed-off-by: Henry Schreiner <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for pytest 9+ configuration formats to the repository review checks. Pytest 9 introduces native TOML configuration (without the ini_options wrapper) in pyproject.toml, as well as standalone pytest.toml and .pytest.toml files.
Key changes:
- Introduces
PytestFileenum to distinguish between legacy (6+), modern (9+), and standalone TOML config locations - Updates all pytest-related checks (PP301-PP309) to work with the new configuration formats
- Adds comprehensive test coverage for the new configuration styles
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/sp_repo_review/checks/pyproject.py | Adds PytestFile enum and pytest() fixture function; updates all PP30x checks to accept pytest fixture tuple |
| tests/test_pyproject.py | Updates existing tests to use new fixture format; adds tests for modern pytest configs and fixture function |
| pyproject.toml | Registers new pytest fixture in entry points |
| docs/pages/guides/pytest.md | Documents both legacy (6+) and modern (9+) pytest configuration formats |
| README.md | Updates check descriptions for PP302 and PP305 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #678.
📚 Documentation preview 📚: https://scientific-python-cookie--681.org.readthedocs.build/