Skip to content

cart.js: No 'new' on util.error #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericingram merged 1 commit into from
Apr 3, 2017
Merged

cart.js: No 'new' on util.error #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions api/v1/cart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,10 +368,10 @@ cart.validateProduct = (schema, data) => {
var productId = product.id;
var variantId = product.variant && product.variant.id;
if (!product.id) {
throw new util.error(400, 'Product not found');
throw util.error(400, 'Product not found');
}
if (product.delivery === 'subscription') {
throw new util.error(400, 'Subscription products cannot be added to a cart');
throw util.error(400, 'Subscription products cannot be added to a cart');
}
if (product.variable && !data.variant_id) {
// Return first variant
Expand All @@ -386,10 +386,10 @@ cart.validateProduct = (schema, data) => {
});
}
if (data.variant_id && !product.variant) {
throw new util.error(400, 'Variant not found for this product (' + product.name + ')');
throw util.error(400, 'Variant not found for this product (' + product.name + ')');
}
if (data.variant_id && !product.variable) {
throw new util.error(400, 'Product is not variable (' + product.name + ')');
throw util.error(400, 'Product is not variable (' + product.name + ')');
}
// Valid
data.product_id = productId;
Expand Down