fix(ci): fix bad use of poetry groups + update to Python 3.12 in publish CI#104
Merged
fix(ci): fix bad use of poetry groups + update to Python 3.12 in publish CI#104
Conversation
cyclimse
commented
Jul 22, 2024
Bemilie
approved these changes
Jul 22, 2024
|
LGTM, difficult to say if it will work without releasing, but since it's a copy of what's done on https://github.com/scaleway/dagster-scaleway, and since it already worked there (https://github.com/scaleway/dagster-scaleway/actions/runs/8813500431), I'd say it should work too 😅 |
norbjd
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What's changed?
Why do we need this?
Fix the CI, which is blocking the deployment of release
v2.0.1I previously relied on a strange behavior, when parsing flags which were lists of strings, poetry would ignore if an element was empty. It now considers this a valid input, so when passing "--only main,", it identifies two groups,
mainand ``. The latter is not a valid group, so it fails.TBH I'm not sure why I chose this approach as opposed to just using
--with, I think there was a specific case where we only needed a non-main dependency group, so I chose this.How have you tested it?
Checklist
Details