add env vars for LDAP Attributes#699
Closed
hknochi wants to merge 1 commit intosameersbn:masterfrom
hknochi:feature/addCustomLDAPAttributes
Closed
add env vars for LDAP Attributes#699hknochi wants to merge 1 commit intosameersbn:masterfrom hknochi:feature/addCustomLDAPAttributes
hknochi wants to merge 1 commit intosameersbn:masterfrom
hknochi:feature/addCustomLDAPAttributes
Conversation
|
looks good to me, did not run it though |
Collaborator
|
LGTM on the first view. ping @sameersbn. |
|
Could this please be merged @sameersbn? |
|
👍👍 |
gjrtimmer
referenced
this pull request
in gjrtimmer/docker-gitlab
Dec 14, 2018
Fixes #699 Fixes #1746 Fixes #1814
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added the possibility to set the attributes for LDAP Users with environment variables