Add Generic OAuth2 provider#2070
Merged
solidnerd merged 7 commits intosameersbn:masterfrom Mar 12, 2020
Merged
Conversation
solidnerd
requested changes
Jan 28, 2020
Collaborator
There was a problem hiding this comment.
Hey,
on the first look, it's okay for me. I would really appreciate a demo setup with keycloak. It could be placed in docs as documentation for others how to setup keycloak and GitLab with Omniauth.
I think this would also valuable for other users and i would like to understand how this works 
✌️ .
BartJoris
force-pushed
the
oauth2_generic
branch
from
202fb62 to
fec5463
Compare
Contributor
Author
|
Hey, |
Collaborator
|
Hey, |
Contributor
Author
|
That's fine for me, thanks! |
bjf893
pushed a commit
to bjf893/docker-gitlab
that referenced
this pull request
Aug 29, 2020
* Add Generic OAuth2 provider * Add docs to test Keycloak on a local environment * Update docs for oauth2_generic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the possibility to use OAuth2 Generic as Omniauth provider.
This can easily be tested by running a local Keyckloak instance: https://hub.docker.com/r/jboss/keycloak/, or if you want I can provide a client on our testing Keycloak.
The code is based on an existing pull request: #1401