Fix: Gitlab Pages Custom Domain Setup#1791
Closed
gjrtimmer wants to merge 2 commits intosameersbn:masterfrom
Closed
Fix: Gitlab Pages Custom Domain Setup#1791gjrtimmer wants to merge 2 commits intosameersbn:masterfrom
gjrtimmer wants to merge 2 commits intosameersbn:masterfrom
Conversation
solidnerd
requested changes
Nov 28, 2018
Contributor
Author
|
@solidnerd Can you restart the Circle-CI. Don't know what caused the failure |
Contributor
Author
|
Rebased to 11.5.1 |
Contributor
Author
|
@solidnerd Rebased |
Collaborator
|
Hey, this will be released with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the Gitlab Pages within a
custom domain setupaccording to the documentation of Gitlab. The container will fail to startnginxdue to the following error:This fix allows the user to disable the gitlab pages proxy when providing their own HTTP Load Balancer for Gitlab Pages.
@solidnerd Request Review.