Closed
Conversation
* this fixes the issue related to https://gitlab.com/gitlab-org/gitlab-ce/issues/43926#note_73018296 Fixes sameersbn#1745
frol2103
force-pushed
the
fixLDAPUsername
branch
from
e203585 to
e3c37b5
Compare
Collaborator
|
Hey @frol2103, can you rebase against master to see the new ci system running on your improvement. |
solidnerd
reviewed
Nov 6, 2018
Collaborator
solidnerd
left a comment
solidnerd
left a comment
There was a problem hiding this comment.
I think you should rebase against master so we see CI running.
gjrtimmer
referenced
this pull request
in gjrtimmer/docker-gitlab
Dec 14, 2018
Fixes #699 Fixes #1746 Fixes #1814
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1745
I am not sure of the procedure to add an array in a env variable but I didn't find any example.
Please do not hesitate to tell if change needs to be made.