Conversation
columnize.go
Outdated
Owner
There was a problem hiding this comment.
This should never really be this large because it is just the formatting of a single line, sans data. I would guess the size would end up being closer to (6 + len(c.Glue)) * columns (%-NNNs<glue> per-column). I'm fine with it though if there is some subtle reason the math is faster this way.
Contributor
Author
There was a problem hiding this comment.
Ah good catch, the extra 8 is wrong. But I think len(width) ~= columns, but it is one less len() call so I will make the change.
Owner
|
@dadgar nice! This is looking really good. Left a few thoughts/comments. |
Contributor
Author
|
Done! |
Owner
|
🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the time and number of allocations:
Old:
BenchmarkColumnWidthCalculator-4 5000 17636705 ns/op
New:
BenchmarkColumnWidthCalculator-4 30000 3215149 ns/op