Code changes to update to 2024 edition #526
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided I would try to make myself useful and update the code to work with the 2024 edition.
The majority of the changes are just specifying unsafe more explicitly. This shouldn't cause any changes in functionality. I tried to have all the formatting changes be in the last commit, but there were a few that made it into the
edition 2021 -> 2024 fixescommit.I'm not sure how you would like to handle the upgrade in terms of versioning and whatnot. Let me know if you would like me to make any changes to the PR (or if you don't want to have these changes merged at all).