Support uninitialized elements in .assign() and .fill() #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trick is simply to traverse the target array using a raw view / raw pointers; this means we don't create any references to potentially-uninitialized values. Assignment `*x = y.clone()` is used where x is a *mut A, y is a &A; this will work as intended when A: Copy; assignment should not need that the value being overwritten, when Copy, is initialized. Unfortunately we use Zip here instead of the older methods (zip_mut_with, unordered_foreach_mut); because Zip implemnets equivalent functionality but in a generic way. The access pattern and performance is not guaranteed to be identical.
Member
Author
|
Benchmarks suggest .fill() is unchanged. Looks like we don't have an assign benchmark. |
Member
Author
|
Source to back us up on that assignment through |
Member
Author
|
Thoughts for next time: Rethink - we introduced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trick is simply to traverse the target array using a raw view / raw
pointers; this means we don't create any references to
potentially-uninitialized values.
Assignment
*x = y.clone()is used where x is a *mut A, y is a &A;this will work as intended when A: Copy; assignment should not need that
the value being overwritten, when Copy, is initialized.
Unfortunately we use Zip here instead of the older methods
(zip_mut_with, unordered_foreach_mut); because Zip implements equivalent
functionality but in a generic way. The access pattern and performance
is not guaranteed to be identical.
Related to issue #685