spec next chunk for trustedlen #150230
Open
spec next chunk for trustedlen #150230
+34
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
bend-n
force-pushed
the
trusted_len_spec_for_iter_next_chunk
branch
from
eccda83 to
4c4a61b
Compare
This comment has been minimized.
This comment has been minimized.
bend-n
force-pushed
the
trusted_len_spec_for_iter_next_chunk
branch
from
4c4a61b to
4a0dbad
Compare
scottmcm
reviewed
Dec 21, 2025
| return Err(unsafe { IntoIter::new_unchecked(array, 0..initialized) }); | ||
| } else { | ||
| // SAFETY: must be at least N elements; safe to unwrap N elements. | ||
| return Ok(from_fn(|_| unsafe { self.next().unwrap_unchecked() })); |
Member
There was a problem hiding this comment.
unsure: Since you're specializing anyway, maybe https://std.noratrieb.dev/x86_64-unknown-linux-gnu/core/iter/traits/unchecked_iterator/trait.UncheckedIterator.html#method.next_unchecked instead?
Suggested change
| return Ok(from_fn(|_| unsafe { self.next().unwrap_unchecked() })); | |
| return Ok(from_fn(|_| unsafe { self.next_unchecked() })); |
Member
|
r? the8472 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.