-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
parser: emit proper error for gen fn in function pointer types
#150196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
why do you put your github account name into commit name also please squash all commits into one, there is no reason to keep 6 commits for this fix |
|
was a mistake 🤦♂️🤦♂️ |
This comment has been minimized.
This comment has been minimized.
|
r? me also could you add a test somewhere in if you have any questions feel free to ask |
|
i see that you added a new two commits that passed a CI, but could you please consider making this
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This PR adds a dedicated parser diagnostic for
gen fnused in function pointer types.Previously, such cases resulted in a generic parse error. The new behavior mirrors the
existing handling for
async fn, improving consistency and error clarity.