Port #[instruction_set] to attribute parser

[Bryntet]

Please note the test changes, and deprecation of E0778 and E0779

In my opinion, all errors related to this attribute are improved I think, except for if you have #[instruction_set(arm::)] in which case there's an error: expected identifier, found <eof>, which is quite unhelpful I think, but this seems to be a limitation of the general attribute parsing flow

r? @JonathanBrouwer

[rustbot]

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[Bryntet]

@rustbot ready

[JonathanBrouwer]

@bors r+ rollup

[bors]

📌 Commit d42c32b has been approved by JonathanBrouwer

It is now in the queue for this repository.

[JonathanBrouwer]

@bors r-
Sorry one more thing

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rust-log-analyzer]

The job x86_64-gnu-gcc failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [ui] tests/ui/attributes/instruction-set.rs stdout ----

error: auxiliary build of /checkout/tests/auxiliary/minicore.rs failed to compile: 
status: exit status: 101
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/auxiliary/minicore.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "-Zcodegen-backend=gcc" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/attributes/instruction-set/libminicore.rlib" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Cpanic=abort" "-Cforce-unwind-tables=yes" "--edition=2024" "--target" "armv5te-none-eabi" "--crate-type" "rlib" "-Cpanic=abort"
stdout: none
--- stderr -------------------------------

thread 'rustc' (99326) panicked at compiler/rustc_codegen_gcc/src/lib.rs:238:13:
Could not load libgccjit.so. Attempted paths: [
---
note: please make sure that you have updated to the latest nightly

note: please attach the file at `/checkout/obj/rustc-ice-2025-12-22T00_17_53-99318.txt` to your bug report

note: compiler flags: -Z threads=1 -Z simulate-remapped-rust-src-base=/rustc/FAKE_PREFIX -Z translate-remapped-path-to-local-path=no -Z ignore-directory-in-diagnostics-source-blocks=/cargo -Z ignore-directory-in-diagnostics-source-blocks=/checkout/vendor -Z codegen-backend=gcc -C codegen-units=1 -Z ui-testing -Z deduplicate-diagnostics=no -Z write-long-types-to-disk=no -C strip=debuginfo -C prefer-dynamic -C rpath -C debuginfo=0 -C panic=abort -C force-unwind-tables=yes --crate-type rlib -C panic=abort

query stack during panic:
end of query stack
------------------------------------------

For more information how to resolve CI failures of this job, visit this link.