Skip to content

Update comment for STAGE0_MISSING_TARGETS #149840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Dec 22, 2025
Merged

Update comment for STAGE0_MISSING_TARGETS #149840

bors merged 1 commit into from
Dec 22, 2025
+7 −5

Conversation

@jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Dec 10, 2025 •
edited
Loading

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2025

The Miri subtree was changed

cc @rust-lang/miri

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 10, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Dec 10, 2025

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2025
@bors

This comment was marked as resolved.

Sign in to view
@jieyouxu jieyouxu force-pushed the bootstrap-missing-stage0 branch from 36fe951 to 48d34c9 Compare December 22, 2025 01:24
@rustbot
Copy link
Collaborator

rustbot commented Dec 22, 2025

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jieyouxu jieyouxu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 22, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Dec 22, 2025

Rerolling since Mark has like 30 in-review PRs
@rustbot reroll

@rustbot rustbot assigned Zalathar and unassigned Mark-Simulacrum Dec 22, 2025
Zalathar
Zalathar reviewed Dec 22, 2025
View reviewed changes
@jieyouxu jieyouxu force-pushed the bootstrap-missing-stage0 branch 2 times, most recently from 75e9176 to bc4737d Compare December 22, 2025 02:29
@Zalathar
Copy link
Member

Zalathar commented Dec 22, 2025

Nit: Since we're modifying this whole comment, could you also replace the // with /// so that it becomes visible as a doc comment in IDE hovers and such?

Zalathar
Zalathar reviewed Dec 22, 2025
View reviewed changes
src/bootstrap/src/core/sanity.rs Outdated
Comment on lines 36 to 38
// Targets can be removed from this list once they are present in the stage 0 compiler during a
// bootstrap compiler bump (typically updating the bootstrap compiler to a newer beta compiler that
// *does* already know about the targets).
Copy link
Member

@Zalathar Zalathar Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this phrasing a bit confusing.

Is the idea that people should feel free to update this list as part of a bootstrap beta bump, if the new stage0 compiler now knows about the missing targets?

Copy link
Member Author

@jieyouxu jieyouxu Dec 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the idea is that it'll happen during the usual release process bootstrap compiler bumps. But such bumps can also rarely happen manually outside of the usual release procedures (I've done that once or twice I think?) but definitely not for updating missing stage 0 target reasons.

Copy link
Member Author

@jieyouxu jieyouxu Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to say

Targets can be removed from this list during the usual release process bootstrap compiler bumps.

... which, I don't know, might be worse?

Copy link
Member

@Zalathar Zalathar Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would at least want to mention again why they can be removed, i.e. because the newly-bumped stage0 compiler now knows about the formerly-missing targets.

Copy link
Member Author

@jieyouxu jieyouxu Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added that remark in de0945b

@jieyouxu jieyouxu force-pushed the bootstrap-missing-stage0 branch from bc4737d to 00013a0 Compare December 22, 2025 02:41
@jieyouxu jieyouxu force-pushed the bootstrap-missing-stage0 branch from 00013a0 to de0945b Compare December 22, 2025 02:54
@Zalathar
Copy link
Member

Zalathar commented Dec 22, 2025

Looks good; r=me if you're done making edits.

@jieyouxu
Copy link
Member Author

jieyouxu commented Dec 22, 2025

@bors r=Zalathar rollup

@bors
Copy link
Collaborator

bors commented Dec 22, 2025

📌 Commit de0945b has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2025
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 22, 2025
Merged
bors added a commit that referenced this pull request Dec 22, 2025
@bors
Auto merge of #150240 - JonathanBrouwer:rollup-anx8c35, r=JonathanBro…
e951f47 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #149840 (Update comment for `STAGE0_MISSING_TARGETS`)
 - #150109 (crash test readme: point to rustc-dev-guide)
 - #150204 (Port `#[cfi_encoding]` to attribute parser)
 - #150237 (Skip tidy target-specific check for `run-make-cargo` too)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e1f41dc into rust-lang:main Dec 22, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 22, 2025
rust-timer added a commit that referenced this pull request Dec 22, 2025
@rust-timer
Unrolled build for #149840
a0c6ffd 
Rollup merge of #149840 - jieyouxu:bootstrap-missing-stage0, r=Zalathar

Update comment for `STAGE0_MISSING_TARGETS`
@jieyouxu jieyouxu deleted the bootstrap-missing-stage0 branch December 22, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zalathar Zalathar Zalathar left review comments

Assignees

@Zalathar Zalathar

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jieyouxu @rustbot @bors @Zalathar @Mark-Simulacrum