drop baseReverseDic since there are only 2 dicts#9
Open
yoavst wants to merge 1 commit intorufushuang:masterfrom
yoavst:patch-2
Open
drop baseReverseDic since there are only 2 dicts#9yoavst wants to merge 1 commit intorufushuang:masterfrom yoavst:patch-2
yoavst wants to merge 1 commit intorufushuang:masterfrom
yoavst:patch-2
Conversation
Improve performance of code by dropping unneeded dict of dicts, hopefully allowing to `getCharFromInt.doFunc` to be inlined by the JVM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve performance of code by dropping unneeded dict of dicts, hopefully allowing to
getCharFromInt.doFuncto be inlined by the JVM.