Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Fix Travis #233

Merged
rebornix merged 4 commits into from
Jan 25, 2018
Merged

Fix Travis #233

rebornix merged 4 commits into from
Jan 25, 2018

Conversation

@wingrunr21
Copy link
Collaborator

@wingrunr21 wingrunr21 commented Dec 16, 2017

This PR does a few things:

  • Adds ruby 2.4 to the build matrix in appveyor
  • Syncs the rubies tested on Travis with appveyor
  • Upgrades the tested node version to the new LTS release
  • Fixes the build to make sure everything is run through nvm

@TeeSeal TeeSeal mentioned this pull request Dec 15, 2017
Merged
2 tasks
@wingrunr21
Copy link
Collaborator Author

wingrunr21 commented Jan 7, 2018

ping @rebornix

orien
orien approved these changes Jan 11, 2018
View reviewed changes
Copy link

@orien orien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@wingrunr21 wingrunr21 closed this Jan 21, 2018
@wingrunr21 wingrunr21 deleted the fix_travis branch January 21, 2018 21:48
@wingrunr21 wingrunr21 restored the fix_travis branch January 25, 2018 01:47
@wingrunr21 wingrunr21 reopened this Jan 25, 2018
@rebornix rebornix merged commit c65e82d into rubyide:master Jan 25, 2018
@Matthelonianxl Matthelonianxl mentioned this pull request Feb 11, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@orien orien orien approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wingrunr21 @orien @rebornix