Skip to content

Use assert_kind_of instead of if + assert(false) #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsbt merged 2 commits into from
Dec 5, 2016
Merged

Use assert_kind_of instead of if + assert(false) #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0947e13
Use assert_kind_of instead of if statement
herwinw Dec 4, 2016
cda29bd
Fixed indentation in test_parser.rb
herwinw Dec 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions test/test_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,10 @@ def test_parseMethodCall

def test_fault
flag, fault = @p.parseMethodResponse(@fault_doc)
assert_equal(flag, false)
unless fault.is_a? XMLRPC::FaultException
assert(false, "must be an instance of class XMLRPC::FaultException")
end
assert_equal(fault.faultCode, 4)
assert_equal(fault.faultString, "an error message")
assert_equal(flag, false)
assert_kind_of(XMLRPC::FaultException, fault, "must be an instance of class XMLRPC::FaultException")
assert_equal(fault.faultCode, 4)
assert_equal(fault.faultString, "an error message")
end

def test_fault_message
Expand Down