Use Array#each instead of while and Array#shift#12
Conversation
|
[I suppose Array#shift was used instead of Array#each here because the array As far as I can see assert_join_threads is used only by TestXMLRPC::WEBrick_Testing#with_server in test/webrick_testing.rb, which doesn't appear to need to spawn threads at all. Perhaps it makes more sense to try to remove this assert_join_threads entirely? |
I'm not completely sure about that, we need something to run the server and something to run the client. But I only had a short look at it. @hsbt Hold your merge horses :) I'll have a better look at this later. |
This was just needless complication of the tests.
|
Looks like @rhenium was right: we do need some threads, but not the ones we used here. This cleans up the code a bit. |
|
👍 Looks good to me! |
No description provided.