Merged
Conversation
Don't emit a CCall.
nirvdrum
reviewed
Nov 21, 2025
| } | ||
|
|
||
| fn inline_string_empty_p(fun: &mut hir::Function, block: hir::BlockId, recv: hir::InsnId, args: &[hir::InsnId], _state: hir::InsnId) -> Option<hir::InsnId> { | ||
| let &[] = args else { return None; }; |
Contributor
There was a problem hiding this comment.
I haven't seen this pattern used outside of ZJIT. There's nothing wrong with it, but I'm curious if it has any benefits over the more pedestrian:
if !args.is_empty() {
return None;
}
Contributor
Author
There was a problem hiding this comment.
I think it's to keep the code ~parallel with other methods in the file where we do actually unpack things from the slice
k0kubun
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't emit a CCall.