Introduce Fiber::Scheduler#fiber_interrupt.#12585
Closed
ioquatix wants to merge 1 commit intoruby:masterfrom
Closed
Introduce Fiber::Scheduler#fiber_interrupt.#12585ioquatix wants to merge 1 commit intoruby:masterfrom
Fiber::Scheduler#fiber_interrupt.#12585ioquatix wants to merge 1 commit intoruby:masterfrom
Conversation
0fd3e5c to
09f1395
Compare
This comment has been minimized.
This comment has been minimized.
54d287e to
47b9bdb
Compare
47b9bdb to
122dabc
Compare
3 tasks
0338268 to
faf5619
Compare
luke-gru
reviewed
Mar 2, 2025
76056a1 to
aeff7f3
Compare
aeff7f3 to
f31d104
Compare
Member
Author
|
Closing in favour of #12839 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby's
IO#closecan causeIO#read,IO#write,IO#wait,IO#wait_readableandIO#wait_writableto be interrupted with an IOError (stream closed on another thread).The fiber scheduler did not implement this for
io_read,io_writeandio_waithooks. Finally after several years, someone made a bug report - see socketry/async#368 for background. In order to solve this problem for the fiber scheduler, we need to expose the ability forIO#closeto interrupt a fiber.This PR introduces a new public C function
rb_io_interruptable_operationwhich takes a callback. During that callback, the code may be interrupted. In addition, we expose that asIO#interruptable_operation{...}which does the same. This allows us to implement IO interruption, e.g.See socketry/io-event#130 for the counterpart PR in the
io-eventgem, e.g. the user code which adopts this feature.