Always set default key bindings in lists#433
Conversation
The default key combinations of many terminal emulators did not match the information in terminfo. To maintain compatibility, the key bindings in the comprehensive list should always be set by default. This cloud fixes ruby/irb#330 home/end/delete key bindings in some cases. Ref: ruby/irb#330
|
A combination of #521 to put the terminal in keypad transmit mode and #434 to add a few key bindings that were missing (in particular the delete key), should be enough to fix it so most terminal emulators, including xterm, will work properly again using just terminfo key bindings and not needing the comprehensive lists. Nevertheless, as near as I can tell this fix can only help not hurt, so I am totally in favor of merging this PR as well. |
|
Can confirm that this fixes the following issue I have with the delete key:
My situation:
|
|
Could you add tests? |
|
I added some pretty comprehensive tests in my PR (#434), so once that is merged we could probably go ahead with this one too. At most all we would need to do for tests is copy some of the asserts from my test_ansi_without_terminfo.rb into test_ansi_with_terminfo.rb, since those bindings will now exist even when terminfo is enabled. |
|
Reminder to probably close this out if we move forward with #567. |
The default key combinations of many terminal emulators did not match the information in
terminfo. To maintain compatibility, the key bindings in the comprehensive list should always be set by default.This cloud fixes ruby/irb#330 home/end/delete key bindings in some cases.