Add workaround for TruffleRuby and do not use File::SHARE_DELETE#114
Merged
hsbt merged 1 commit intoruby:masterfrom Jan 10, 2025
Merged
Conversation
Member
Author
|
Also are maintainers open to add TruffleRuby on logger's CI? There is only one failing test now: |
This was referenced Jan 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix logger on TruffleRuby.
TruffleRuby is missing a
File::SHARE_DELETEconstant that is in logger since #102. It was fixed in the TruffleRuby trunk and will be released in the next version.This proposed temporary workaround in logger is needed to make it work on the current TruffleRuby release.
TruffleRuby issue truffleruby/truffleruby#3745