Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I intended to fix #104 but this still results in a broken link.
Because https://ruby.github.io/logger/ hadn't been rebuilt in awhile https://ruby.github.io/logger/LICENSE_txt.html exists but the link on https://ruby.github.io/logger/index.html points to https://ruby.github.io/logger/LICENSE.txt which does not.
With the change in this PR, the updated license files get added, and the link changed to /BSDL which does not.
There must be some RDoc convention or hint so that the right URL gets emitted that I do not know.
Still, this PR at least allows the rdoc task to succeed (it failed before as LICENSE.txt no longer exists).