Add max_heap_size option and related error variant#229
Merged
rscarson merged 4 commits intorscarson:masterfrom Oct 18, 2024
Merged
Add max_heap_size option and related error variant#229rscarson merged 4 commits intorscarson:masterfrom
rscarson merged 4 commits intorscarson:masterfrom
Conversation
Owner
|
The only issue I see is that more recent versions of deno_cache pin tokio at 1.36.0 If you can use that version this is golden! |
Contributor
Author
|
Ah yep. Pinned now. Hopefully deno will unpin soon given upstream fix. denoland/deno#24958 (comment) |
flightofthefox
force-pushed
the
max-heap-size
branch
from
b86dcaf to
fc226dc
Compare
Owner
|
Seems one of the tests is failing in a very peculiar way |
Contributor
Author
Hah yes. I was setting a very small heap (4MB) in the exhaustion test but that's no longer large enough to initialize the runtime with the updated deno deps 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For your consideration: this PR adds a new
max_heap_sizeoption to RuntimeOptions. Merging the provided setting into any existingisolate_optionsif given.Using a
CancellationTokento sync the termination across both inner and outer runtime, as just terminating the isolate leaves tokio hanging... needed to modify the on_block call to abort its inner future also.LMK if you think it's useful, or if there's a better way to go about it.