[hist] Ndim: correctly set axes title from histo title#21493
[hist] Ndim: correctly set axes title from histo title#21493dpiparo merged 1 commit intoroot-project:masterfrom
Conversation
and preserve axis titles if any if the c'tor is invoked passing a vector of axes. Fixes root-project#21484
|
|
||
| TString axisTitle; | ||
| Int_t dim = 0; | ||
| while(titleStr.Tokenize(axisTitle, from, ";")) { |
There was a problem hiding this comment.
Thanks! Non-important: a more modern alternative to Tokenize could be:
ROOT::Split (https://root.cern.ch/doc/master/StringUtils_8hxx_source.html)
There was a problem hiding this comment.
Indeed. Since we were dealing with TStrings, I thought I would stick to the way the code was written at the time.
Ideally, what could be also useful, is a tokenizer that produces a collection of string_view pointing to the string being tokenized, to avoid all copies. In this and many other cases, there would be no measurable impact on the performance, but in principle that is the "right" thing to do maybe....
Test Results 22 files 22 suites 3d 7h 40m 2s ⏱️ Results for commit e19141b. |
|
/backport to 6.36, 6.38 |
3 participants
and preserve axis titles if any if the c'tor is invoked passing a vector of axes.
Fixes #21484