[ntuple] Remove unused RNTupleJoinTableMethods#21468
Open
enirolf wants to merge 2 commits intoroot-project:masterfrom
Open
[ntuple] Remove unused RNTupleJoinTableMethods#21468enirolf wants to merge 2 commits intoroot-project:masterfrom
RNTupleJoinTableMethods#21468enirolf wants to merge 2 commits intoroot-project:masterfrom
Conversation
These methods currently have no practical use. They can be re-added if the need for them arises again.
The TODO on line 138 of `RNTupleJoinTable.cxx` will be addressed in a follow-up PR.
Test Results 22 files 22 suites 3d 4h 59m 59s ⏱️ For more details on these failures, see this check. Results for commit 697333f. ♻️ This comment has been updated with latest results. |
silverweed
reviewed
Mar 4, 2026
| ROOT::NTupleSize_t | ||
| ROOT::Experimental::Internal::RNTupleJoinTable::GetEntryIndex(const std::vector<void *> &valuePtrs) const | ||
| ROOT::NTupleSize_t ROOT::Experimental::Internal::RNTupleJoinTable::GetEntryIndex(const std::vector<void *> &valuePtrs, | ||
| bool throwOnMultipleMatches) const |
Contributor
There was a problem hiding this comment.
I find this bool param a bit odd: can't the function always return the first index + e.g. a bool telling whether multiple matches exist? At that point the caller can decide if they want to throw or not.
If throwing on multiple matches was a common enough pattern then I'd see the point of this, but it seems that the caller almost never wants to throw..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These methods currently are not used in practice, or foreseen to be used. They can be re-added if the need arises.