[ntuple] Support reading alternative types through the RNTupleProcessor#21462
Draft
enirolf wants to merge 7 commits intoroot-project:masterfrom
Draft
[ntuple] Support reading alternative types through the RNTupleProcessor#21462enirolf wants to merge 7 commits intoroot-project:masterfrom
RNTupleProcessor#21462enirolf wants to merge 7 commits intoroot-project:masterfrom
Conversation
This changes requires moving the ownership of all fields from an internally stored `RNTupleModel` in each processor (`fProtoModel`) to the `RNTupleProcessorEntry`. Full removal of `fProtoModel` is taken car of in the next commit. This change also enables proper handling of subfields, for wich a test will be added in a separate commit.
enirolf
changed the title
RNTupleProcessorRNTupleProcessor
Test Results 22 files 22 suites 3d 3h 59m 46s ⏱️ Results for commit ec4f94c. ♻️ This comment has been updated with latest results. |
To distinguish them internally from regular fields that have been added explicitly by the user.
This change also includes a different way to handle field/processor naming conflicts, which previously relied on the `fProtoModel`, plus an additional test for this
To make sure that fields of "second chains" are also added correctly to the processor.
enirolf
force-pushed
the
ntuple-processor-alternative-types
branch
from
ec4f94c to
091710b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes requires moving the ownership of all fields from an internally stored
RNTupleModelin each processor (fProtoModel) to theRNTupleProcessorEntry. In turn, potential namin conflicts when auxiliary RNTuples in a join have the same name as a field in the primary RNTuple are now also handled differently, since this used to rely on thefProtoModel.This change implicitly adds proper support for requesting subfields, for which tests have been added.