io: Correct handling of byte count pos in TBufferFile::ReadObjectAny#21192
Open
pcanal wants to merge 21 commits intoroot-project:Arlesiennefrom
Open
io: Correct handling of byte count pos in TBufferFile::ReadObjectAny#21192pcanal wants to merge 21 commits intoroot-project:Arlesiennefrom
pcanal wants to merge 21 commits intoroot-project:Arlesiennefrom
Conversation
Member
Author
|
Note that 588b29e was also not reviewed. |
Test Results 22 files 22 suites 3d 4h 53m 53s ⏱️ Results for commit ef03d21. ♻️ This comment has been updated with latest results. |
Collaborator
|
Closing #20498 since it seems this is an alternative / better approach |
jblomer
approved these changes
Feb 9, 2026
pcanal
requested review from
bellenot,
dpiparo and
guitargeek
as code owners
pcanal
force-pushed
the
Arlesienne_ByteCount
branch
2 times, most recently
from
1ca66ec to
33e27a1
Compare
Member
Author
bellenot
reviewed
Feb 23, 2026
Member
Author
jblomer
reviewed
Feb 23, 2026
pcanal
force-pushed
the
Arlesienne_ByteCount
branch
from
fbaed6e to
677a609
Compare
pcanal
requested review from
hageboeck,
martamaja10 and
vepadulano
as code owners
pcanal
force-pushed
the
Arlesienne_ByteCount
branch
from
677a609 to
61e48bd
Compare
pcanal
force-pushed
the
Arlesienne_ByteCount
branch
from
61e48bd to
0b030d7
Compare
jblomer
approved these changes
Feb 26, 2026
This fixes TBufferFile::ReadObjectAny handling of long range byte counts
Those were essentially replaced by a 'set the cursor to the end' call in commit 7d25b75. It is dubious whether these changes are needed or were an heurestic to ignore (temporarily !?) race conditions.
Due to the need for using a stack of bytecount position, we can no longer support redundant calls to CheckByteCount.
pcanal
force-pushed
the
Arlesienne_ByteCount
branch
from
0b030d7 to
1f88b1f
Compare
This simplify the implementation of calling `ReserveByteCount` and then `SetByteCount` and could also simplify removing the use of the ByteCountStack in some/most cases. Note: `ReserveByteCount` is protected and the existing code that does the same semantic action was only recording the position in a 32 bits integer. That code needs to be updated by either making `ReserverByteCount` public (making removal of external use of the ByteCountStack more difficult) or by introducing a RAII that hides the size of the integer.
In order to allow using the roottest CMake macro outside of the roottest sub-directory, we need to make the variable used by those macros 'cache variable' so that they can use elsewhere. This is a hack and works only after the second CMake configuration/invocation.
When using the Microsoft Visual Studio generator we have the exact same problem, that it might trigger a rebuild of ROOT so we need to apply the same solution. See 06e00a2. PS. We might want to eventually rename the resource lock.
It is need by at least Ninja and the Visual Studio generator
pcanal
force-pushed
the
Arlesienne_ByteCount
branch
from
1f88b1f to
ef03d21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a missing commit for #21183 which was merge a bit too soon.