[io] read versioned class from file even if in-memory-class is unversioned#18660
Open
ferdymercury wants to merge 1 commit intoroot-project:masterfrom
Open
[io] read versioned class from file even if in-memory-class is unversioned#18660ferdymercury wants to merge 1 commit intoroot-project:masterfrom
ferdymercury wants to merge 1 commit intoroot-project:masterfrom
Conversation
ferdymercury
commented
May 8, 2025
ferdymercury
commented
May 8, 2025
ferdymercury
commented
May 8, 2025
ferdymercury
commented
May 8, 2025
pcanal
reviewed
May 8, 2025
Test Results 22 files 22 suites 3d 7h 3m 26s ⏱️ For more details on these failures, see this check. Results for commit 336f18d. ♻️ This comment has been updated with latest results. |
ferdymercury
commented
May 8, 2025
pcanal
reviewed
May 8, 2025
ferdymercury
commented
May 9, 2025
ferdymercury
commented
May 9, 2025
Collaborator
Author
|
@pcanal |
…ioned Fixes https://its.cern.ch/jira/browse/ROOT-5306 [io] add test for unversioned reading
Member
|
Closing and Reopening to rebase the PR and retest. |
Member
|
@pcanal this is to be considered all green: the 3 tests failing on alma9 march native are due to a glitch in the website infra. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Fixes https://its.cern.ch/jira/browse/ROOT-5306
Reproducer:
with MySubClass.cxx
class MySubClass { public: int id; ClassDef(MySubClass, 3) };and MySubClassUnv.cxx
class MySubClass { public: int id; };Checklist: