[TMVA][SOFIE] Use uint8_t instead of bool in return types#18302
Merged
dpiparo merged 1 commit intoroot-project:masterfrom Apr 14, 2025
Merged
[TMVA][SOFIE] Use uint8_t instead of bool in return types#18302dpiparo merged 1 commit intoroot-project:masterfrom
uint8_t instead of bool in return types#18302dpiparo merged 1 commit intoroot-project:masterfrom
Conversation
guitargeek
changed the title
char instead of bool in return typesunsigned char instead of bool in return types
guitargeek
force-pushed
the
tmva_sofie_bool
branch
from
1699eeb to
aa9cfd9
Compare
Test Results 18 files 18 suites 4d 19h 7m 10s ⏱️ For more details on these failures, see this check. Results for commit 871f7a9. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
tmva_sofie_bool
branch
2 times, most recently
from
ae9e986 to
a92a2a0
Compare
guitargeek
force-pushed
the
tmva_sofie_bool
branch
2 times, most recently
from
05d2d4d to
5ebcdff
Compare
The `std::vector<bool>` is a special class that doesn't wrap contiguous memory. It limits the usability of the return object (e.g. the memory can't be adopted copy-free by a NumPy array). It prevents us from using C-style arrays under the hood and differentiating through the inference function.
guitargeek
force-pushed
the
tmva_sofie_bool
branch
from
5ebcdff to
871f7a9
Compare
guitargeek
changed the title
unsigned char instead of bool in return typesuint8_t instead of bool in return types
sanjibansg
approved these changes
Apr 14, 2025
Collaborator
sanjibansg
left a comment
sanjibansg
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this contribution Jonas!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
std::vector<bool>is a special class that doesn't wrap contiguousmemory. It limits the usability of the return object (e.g. the memory
can't be adopted copy-free by a NumPy array). It prevents us
from using C-style arrays under the hood and differentiating through the
inference function.
Also, further simplify the code that deals with the return objects.