Tweaks for AddressSanitizer#11621
Merged
hahnjo merged 2 commits intoroot-project:masterfrom Oct 24, 2022
Merged
Conversation
|
Starting build on |
Member
Author
|
See root-project/roottest#910 for the roottest side of the changes |
etejedor
reviewed
Oct 21, 2022
etejedor
reviewed
Oct 21, 2022
|
Starting build on |
They need to be preloaded into the Python process, but must not be propagated into instrumented executables such as root or rootcling.
|
Starting build on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address a number of AddressSanitizer failures with Python tests, due to the way we need to preload the ASan runtime and our configuration.
If I count correctly (there were a number of failures introduced last night, so I don't have a proper baseline), this fixes 7 tests:
pyunittests-pyroot-import-load-libstutorial-roofit-rf104_classfactory-pyroottest-python-JupyROOT-simpleCppMagic_notebookroottest-python-JupyROOT-thread_local_notebookroottest-python-JupyROOT-ROOT_kernel_notebookroottest-python-basic-basicroottest-python-regression-regressionMoreover,
tutorial-rcanvas-df104-pywill show a proper AdressSanitizer failure.