Conversation
|
@sodiumjoe please push a new commit to your branch so the github (buggy) approve workflows run UX will get triggered again, and I can approve the run |
|
@CharlieHelps please do a thorough review of this PR to determine if it's ready to merge. Look at the diff, reviews, comments, and referenced issues/docs/links to build a complete understanding. Then respond with a comment that includes a list of MUST fix items that must be fixed before the the PR is merged, and a list of IMPROVEMENTS that shouldn't block the merge but may be quick improvements or things that could be addressed in a follow up PR. The MUST fix items should explain exactly what's wrong and what needs to change to resolve the problem. Both should be numbered lists and the IMPROVEMENTS list should continue counting up from the MUST list. It's OK if there are no IMPROVEMENTS or MUST fix items, you can just omit the lists. |
|
I pulled the branch locally and reviewed the diff + new fixtures. Local run: MUST fix
IMPROVEMENTS |
Rollup Plugin Name:
commonjsThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
resolves #1771
Description
This fix resolves a bug where conditional exports in LogicalExpression (
||) with falsy right operands are not properly transformed, causing "ReferenceError: exports is not defined" in ES module builds.